Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2025-12-16 16:30:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

📄 refactor: Add Provider Fallback for Media Encoding using Client Endpoint (#10656)
Some checks are pending
Docker Dev Branch Images Build / build (Dockerfile, lc-dev, node) (push) Waiting to run
Details
Docker Dev Branch Images Build / build (Dockerfile.multi, lc-dev-api, api-build) (push) Waiting to run
Details
Docker Dev Images Build / build (Dockerfile, librechat-dev, node) (push) Waiting to run
Details
Docker Dev Images Build / build (Dockerfile.multi, librechat-dev-api, api-build) (push) Waiting to run
Details
Sync Locize Translations & Create Translation PR / Sync Translation Keys with Locize (push) Waiting to run
Details
Sync Locize Translations & Create Translation PR / Create Translation PR on Version Published (push) Blocked by required conditions
Details

Browse source 
When using direct endpoints (e.g., Google) instead of Agents, `this.options.agent` is undefined, causing provider detection to fail. This resulted in "Unknown content type document" errors for Google/Gemini PDF uploads.

Added `?? this.options.endpoint` fallback in addDocuments(), addVideos(), and addAudios() methods to ensure correct provider detection for all endpoint types.
This commit is contained in:
Zihao Zhou 2025-11-25 14:07:37 -08:00 • committed by GitHub
parent 8b7af65265
commit 5b8f0cba04
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

12
api/app/clients/BaseClient.js
View file

@ -1213,8 +1213,8 @@ class BaseClient {
this.options.req, this.options.req,
attachments, attachments,
{ {
provider: this.options.agent?.provider, provider: this.options.agent?.provider ?? this.options.endpoint,
endpoint: this.options.agent?.endpoint, endpoint: this.options.agent?.endpoint ?? this.options.endpoint,
useResponsesApi: this.options.agent?.model_parameters?.useResponsesApi, useResponsesApi: this.options.agent?.model_parameters?.useResponsesApi,
}, },
getStrategyFunctions, getStrategyFunctions,
@ -1231,8 +1231,8 @@ class BaseClient {
this.options.req, this.options.req,
attachments, attachments,
{ {
provider: this.options.agent?.provider, provider: this.options.agent?.provider ?? this.options.endpoint,
endpoint: this.options.agent?.endpoint, endpoint: this.options.agent?.endpoint ?? this.options.endpoint,
}, },
getStrategyFunctions, getStrategyFunctions,
); );
@ -1246,8 +1246,8 @@ class BaseClient {
this.options.req, this.options.req,
attachments, attachments,
{ {
provider: this.options.agent?.provider, provider: this.options.agent?.provider ?? this.options.endpoint,
endpoint: this.options.agent?.endpoint, endpoint: this.options.agent?.endpoint ?? this.options.endpoint,
}, },
getStrategyFunctions, getStrategyFunctions,
); );