Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2026-01-10 04:28:50 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

feat: enforce at least one owner requirement for permission updates and add corresponding localization messages

Browse source
This commit is contained in:
Atef Bellaaj 2025-06-18 18:09:55 +02:00 • committed by Danny Avila
parent 669af746ed
commit 57084f2caa
No known key found for this signature in database
GPG key ID: BF31EEB2C5CA0956
3 changed files with 22 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
client/src/components/SidePanel/Agents/Sharing/ManagePermissionsDialog.tsx
View file

@ -165,6 +165,11 @@ export default function ManagePermissionsDialog({
const totalShares = managedShares.length + (managedIsPublic ? 1 : 0);
const originalTotalShares = currentShares.length + (isPublic ? 1 : 0);
// Check if there's at least one owner (user, group, or public with owner role)
const hasAtLeastOneOwner =
managedShares.some((share) => share.accessRoleId === ACCESS_ROLE_IDS.AGENT_OWNER) ||
(managedIsPublic && managedPublicRole === ACCESS_ROLE_IDS.AGENT_OWNER);
return (
<OGDialog open={isModalOpen} onOpenChange={setIsModalOpen}>
<OGDialogTrigger asChild>
@ -281,7 +286,12 @@ export default function ManagePermissionsDialog({
</OGDialogClose>
<Button
onClick={handleSaveChanges}
disabled={updatePermissionsMutation.isLoading || !hasChanges || isLoadingPermissions}
disabled={
updatePermissionsMutation.isLoading ||
!hasChanges ||
isLoadingPermissions ||
!hasAtLeastOneOwner
}
className="min-w-[120px]"
>
{updatePermissionsMutation.isLoading ? (
@ -300,6 +310,12 @@ export default function ManagePermissionsDialog({
* {localize('com_ui_unsaved_changes')}
</div>
)}
{!hasAtLeastOneOwner && hasChanges && (
<div className="text-xs text-red-600 dark:text-red-400">
* {localize('com_ui_at_least_one_owner_required')}
</div>
)}
</div>
</OGDialogContent>
</OGDialog>

3
client/src/locales/de/translation.json
View file

@ -963,5 +963,6 @@
"com_ui_unsaved_changes": "Sie haben ungespeicherte Änderungen",
"com_ui_share_with_everyone": "Mit allen teilen",
"com_ui_make_agent_available_all_users": "Diesen Agenten für alle LibreChat-Benutzer verfügbar machen",
"com_ui_public_access_level": "Öffentliche Zugriffsebene"
"com_ui_public_access_level": "Öffentliche Zugriffsebene",
"com_ui_at_least_one_owner_required": "Mindestens ein Besitzer ist erforderlich"
}

5
client/src/locales/en/translation.json
View file

@ -1095,5 +1095,6 @@
"com_ui_unsaved_changes": "You have unsaved changes",
"com_ui_share_with_everyone": "Share with everyone",
"com_ui_make_agent_available_all_users": "Make this agent available to all LibreChat users",
"com_ui_public_access_level": "Public access level"
}
"com_ui_public_access_level": "Public access level",
"com_ui_at_least_one_owner_required": "At least one owner is required"
}