🔧 refactor: Add and use PrincipalType Enum

- Replaced string literals for principal types ('user', 'group', 'public') with the new PrincipalType enum across various models, services, and tests for improved type safety and consistency.
- Updated permission handling in multiple files to utilize the PrincipalType enum, enhancing maintainability and reducing potential errors.
- Ensured all relevant tests reflect these changes to maintain coverage and functionality.

api/models/Agent.spec.js

@@ -14,7 +14,7 @@ const mongoose = require('mongoose');
 const { v4: uuidv4 } = require('uuid');
 const { agentSchema } = require('@librechat/data-schemas');
 const { MongoMemoryServer } = require('mongodb-memory-server');
-const { AccessRoleIds, ResourceType } = require('librechat-data-provider');
+const { AccessRoleIds, ResourceType, PrincipalType } = require('librechat-data-provider');
 const {
   getAgent,
   loadAgent,
@@ -500,7 +500,7 @@ describe('models/Agent', () => {
 
       // Grant permissions (simulating sharing)
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: authorId,
         resourceType: ResourceType.AGENT,
         resourceId: agent._id,

api/models/File.spec.js

@@ -2,7 +2,7 @@ const mongoose = require('mongoose');
 const { v4: uuidv4 } = require('uuid');
 const { createModels } = require('@librechat/data-schemas');
 const { MongoMemoryServer } = require('mongodb-memory-server');
-const { AccessRoleIds, ResourceType } = require('librechat-data-provider');
+const { AccessRoleIds, ResourceType, PrincipalType } = require('librechat-data-provider');
 const { grantPermission } = require('~/server/services/PermissionService');
 const { getFiles, createFile } = require('./File');
 const { seedDefaultRoles } = require('~/models');
@@ -115,7 +115,7 @@ describe('File Access Control', () => {
 
       // Grant EDIT permission to user on the agent
       await grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: userId,
         resourceType: ResourceType.AGENT,
         resourceId: agent._id,
@@ -232,7 +232,7 @@ describe('File Access Control', () => {
 
       // Grant only VIEW permission to user on the agent
       await grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: userId,
         resourceType: ResourceType.AGENT,
         resourceId: agent._id,
@@ -290,7 +290,7 @@ describe('File Access Control', () => {
 
       // Grant EDIT permission to user on the agent
       await grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: userId,
         resourceType: ResourceType.AGENT,
         resourceId: agent._id,

api/models/Prompt.spec.js

@@ -6,6 +6,7 @@ const {
   SystemRoles,
   ResourceType,
   AccessRoleIds,
+  PrincipalType,
   PermissionBits,
 } = require('librechat-data-provider');
 
@@ -151,7 +152,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Manually grant permissions as would happen in the route
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.owner._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testGroup._id,
@@ -163,7 +164,7 @@ describe('Prompt ACL Permissions', () => {
       const aclEntry = await AclEntry.findOne({
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testGroup._id,
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.owner._id,
       });
 
@@ -195,7 +196,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Grant owner permissions
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.owner._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testPromptGroup._id,
@@ -233,7 +234,7 @@ describe('Prompt ACL Permissions', () => {
     it('user with viewer role should only have view access', async () => {
       // Grant viewer permissions
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.viewer._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testPromptGroup._id,
@@ -355,7 +356,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Grant edit permissions to the group
       await permissionService.grantPermission({
-        principalType: 'group',
+        principalType: PrincipalType.GROUP,
         principalId: testGroups.editors._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testPromptGroup._id,
@@ -423,7 +424,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Grant public view access to publicPromptGroup
       await permissionService.grantPermission({
-        principalType: 'public',
+        principalType: PrincipalType.PUBLIC,
         principalId: null,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: publicPromptGroup._id,
@@ -433,7 +434,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Grant only owner access to privatePromptGroup
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.owner._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: privatePromptGroup._id,
@@ -504,7 +505,7 @@ describe('Prompt ACL Permissions', () => {
 
       // Grant permission
       await permissionService.grantPermission({
-        principalType: 'user',
+        principalType: PrincipalType.USER,
         principalId: testUsers.owner._id,
         resourceType: ResourceType.PROMPTGROUP,
         resourceId: testPromptGroup._id,

api/models/PromptGroupMigration.spec.js

@@ -6,6 +6,7 @@ const {
   Constants,
   ResourceType,
   AccessRoleIds,
+  PrincipalType,
   PermissionBits,
 } = require('librechat-data-provider');
 
@@ -158,7 +159,7 @@ describe('PromptGroup Migration Script', () => {
     const globalOwnerEntry = await AclEntry.findOne({
       resourceType: ResourceType.PROMPTGROUP,
       resourceId: globalPromptGroup._id,
-      principalType: 'user',
+      principalType: PrincipalType.USER,
       principalId: testOwner._id,
     });
     expect(globalOwnerEntry).toBeTruthy();
@@ -167,7 +168,7 @@ describe('PromptGroup Migration Script', () => {
     const globalPublicEntry = await AclEntry.findOne({
       resourceType: ResourceType.PROMPTGROUP,
       resourceId: globalPromptGroup._id,
-      principalType: 'public',
+      principalType: PrincipalType.PUBLIC,
     });
     expect(globalPublicEntry).toBeTruthy();
     expect(globalPublicEntry.permBits).toBe(viewerRole.permBits);
@@ -176,7 +177,7 @@ describe('PromptGroup Migration Script', () => {
     const privateOwnerEntry = await AclEntry.findOne({
       resourceType: ResourceType.PROMPTGROUP,
       resourceId: privatePromptGroup._id,
-      principalType: 'user',
+      principalType: PrincipalType.USER,
       principalId: testOwner._id,
     });
     expect(privateOwnerEntry).toBeTruthy();
@@ -185,7 +186,7 @@ describe('PromptGroup Migration Script', () => {
     const privatePublicEntry = await AclEntry.findOne({
       resourceType: ResourceType.PROMPTGROUP,
       resourceId: privatePromptGroup._id,
-      principalType: 'public',
+      principalType: PrincipalType.PUBLIC,
     });
     expect(privatePublicEntry).toBeNull();
   });
@@ -208,7 +209,7 @@ describe('PromptGroup Migration Script', () => {
 
     // Grant permission to one promptGroup manually (simulating it already has ACL)
     await AclEntry.create({
-      principalType: 'user',
+      principalType: PrincipalType.USER,
       principalId: testOwner._id,
       principalModel: 'User',
       resourceType: ResourceType.PROMPTGROUP,