From 47533736e37130c3e6fcabf41545c3d7b217a3a7 Mon Sep 17 00:00:00 2001 From: Dan Orlando Date: Thu, 18 May 2023 12:12:19 -0700 Subject: [PATCH] fix: turn off react-in-jsx-scope rule (#317) --- .eslintrc.js | 1 + eslintrc-stripped.js | 99 ++++++++++++++++++++++---------------------- 2 files changed, 50 insertions(+), 50 deletions(-) diff --git a/.eslintrc.js b/.eslintrc.js index 7d452e7d54..64c3d023ba 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -22,6 +22,7 @@ module.exports = { }, plugins: ['react', 'react-hooks', '@typescript-eslint'], rules: { + 'react/react-in-jsx-scope': 'off', '@typescript-eslint/ban-ts-comment': ['error', { 'ts-ignore': 'allow-with-description' }], indent: ['error', 2, { SwitchCase: 1 }], 'max-len': [ diff --git a/eslintrc-stripped.js b/eslintrc-stripped.js index 9aeb1e10e4..95af5567d3 100644 --- a/eslintrc-stripped.js +++ b/eslintrc-stripped.js @@ -4,80 +4,79 @@ module.exports = { es2021: true, node: true, commonjs: true, - es6: true, + es6: true }, - extends: [ - "prettier", - ], + extends: ['prettier'], parser: '@typescript-eslint/parser', parserOptions: { - ecmaVersion: "latest", - sourceType: "module", + ecmaVersion: 'latest', + sourceType: 'module', ecmaFeatures: { - jsx: true, - }, + jsx: true + } }, - plugins: ["react", "react-hooks", "@typescript-eslint"], + plugins: ['react', 'react-hooks', '@typescript-eslint'], rules: { - indent: ["error", 2, { SwitchCase: 1 }], - "max-len": [ - "error", + 'react/react-in-jsx-scope': 'off', + indent: ['error', 2, { SwitchCase: 1 }], + 'max-len': [ + 'error', { code: 150, ignoreStrings: true, ignoreTemplateLiterals: true, - ignoreComments: true, - }, + ignoreComments: true + } ], - "linebreak-style": 0, - "arrow-parens": [2, "as-needed", { requireForBlockBody: true }], + 'linebreak-style': 0, + // 'arrow-parens': [2, 'as-needed', { requireForBlockBody: true }], // 'no-plusplus': ['error', { allowForLoopAfterthoughts: true }], - "no-console": "off", - "import/extensions": "off", - "no-promise-executor-return": "off", - "no-param-reassign": "off", - "no-continue": "off", - "no-restricted-syntax": "off", - "react/prop-types": ["off"], - "react/display-name": ["off"], + 'no-console': 'off', + 'import/extensions': 'off', + 'no-promise-executor-return': 'off', + 'no-param-reassign': 'off', + 'no-continue': 'off', + 'no-restricted-syntax': 'off', + 'react/prop-types': ['off'], + 'react/display-name': ['off'] }, overrides: [ { - files: ["**/*.ts", "**/*.tsx, **/*.js, **/*.jsx"], + files: ['**/*.ts', '**/*.tsx, **/*.js, **/*.jsx'], rules: { - "no-unused-vars": "off", // off because it conflicts with '@typescript-eslint/no-unused-vars' - "react/display-name": "off", - "@typescript-eslint/no-unused-vars": "warn", - }, + 'no-unused-vars': 'off', // off because it conflicts with '@typescript-eslint/no-unused-vars' + 'react/display-name': 'off', + '@typescript-eslint/no-unused-vars': 'warn' + } }, { - files: ["rollup.config.js", ".eslintrc.js", "jest.config.js"], + files: ['rollup.config.js', '.eslintrc.js', 'jest.config.js'], env: { - node: true, - }, + node: true + } }, { files: [ - "**/*.test.js", - "**/*.test.jsx", - "**/*.test.ts", - "**/*.test.tsx", - "**/*.spec.js", - "**/*.spec.jsx", - "**/*.spec.ts", - "**/*.spec.tsx", - "setupTests.js", + '**/*.test.js', + '**/*.test.jsx', + '**/*.test.ts', + '**/*.test.tsx', + '**/*.spec.js', + '**/*.spec.jsx', + '**/*.spec.ts', + '**/*.spec.tsx', + 'setupTests.js' ], env: { jest: true, - node: true, + node: true }, rules: { - "react/display-name": "off", - "react/prop-types": "off", - "react/no-unescaped-entities": "off", - }, - }, + 'react/display-name': 'off', + 'react/prop-types': 'off', + 'react/no-unescaped-entities': 'off' + } + } ], settings: { react: { @@ -85,7 +84,7 @@ module.exports = { // default to "createReactClass" pragma: 'React', // Pragma to use, default to "React" fragment: 'Fragment', // Fragment to use (may be a property of ), default to "Fragment" - version: 'detect', // React version. "detect" automatically picks the version you have installed. - }, - }, + version: 'detect' // React version. "detect" automatically picks the version you have installed. + } + } };