🛡️ feat: Optimize and Improve Anonymity of SharedLinks (#3543)

* ci: add spec for validateImageRequest

* chore: install nanoid and run npm audit fix

* refactor: optimize and further anonymize shared links data

* ci: add SharedLink specs

* feat: anonymize asst_id's

* ci: tests actually failing, to revisit later

* fix: do not anonymize authenticated shared links query

* refactor: Update ShareView component styling

* refactor: remove nested ternary

* refactor: no nested ternaries

* fix(ShareView): eslint warnings

* fix(eslint): remove nested terns
This commit is contained in:
Danny Avila 2024-08-05 03:34:00 -04:00 committed by GitHub
parent 3e0f95458f
commit 458dc9c88e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 2340 additions and 890 deletions

View file

@ -41,20 +41,25 @@ function ChatView({ index = 0 }: { index?: number }) {
defaultValues: { text: '' },
});
let content: JSX.Element | null | undefined;
if (isLoading && conversationId !== 'new') {
content = (
<div className="flex h-screen items-center justify-center">
<Spinner className="opacity-0" />
</div>
);
} else if (messagesTree && messagesTree.length !== 0) {
content = <MessagesView messagesTree={messagesTree} Header={<Header />} />;
} else {
content = <Landing Header={<Header />} />;
}
return (
<ChatFormProvider {...methods}>
<ChatContext.Provider value={chatHelpers}>
<AddedChatContext.Provider value={addedChatHelpers}>
<Presentation useSidePanel={true}>
{isLoading && conversationId !== 'new' ? (
<div className="flex h-screen items-center justify-center">
<Spinner className="opacity-0" />
</div>
) : messagesTree && messagesTree.length !== 0 ? (
<MessagesView messagesTree={messagesTree} Header={<Header />} />
) : (
<Landing Header={<Header />} />
)}
{content}
<div className="w-full border-t-0 pl-0 pt-2 dark:border-white/20 md:w-[calc(100%-.5rem)] md:border-t-0 md:border-transparent md:pl-0 md:pt-0 md:dark:border-transparent">
<ChatForm index={index} />
<Footer />

View file

@ -49,9 +49,9 @@ function SharedLinkDeleteButton({
<TooltipProvider delayDuration={250}>
<Tooltip>
<TooltipTrigger asChild>
<span onClick={handleDelete}>
<button id="delete-shared-link" aria-label="Delete shared link" onClick={handleDelete}>
<TrashIcon />
</span>
</button>
</TooltipTrigger>
<TooltipContent side="top" sideOffset={0}>
{localize('com_ui_delete')}

View file

@ -18,52 +18,61 @@ function SharedView() {
// configure document title
let docTitle = '';
if (config?.appTitle && data?.title) {
docTitle = `${data?.title} | ${config.appTitle}`;
if (config?.appTitle != null && data?.title != null) {
docTitle = `${data.title} | ${config.appTitle}`;
} else {
docTitle = data?.title || config?.appTitle || document.title;
docTitle = data?.title ?? config?.appTitle ?? document.title;
}
useDocumentTitle(docTitle);
let content: JSX.Element;
if (isLoading) {
content = (
<div className="flex h-screen items-center justify-center">
<Spinner className="" />
</div>
);
} else if (data && messagesTree && messagesTree.length !== 0) {
content = (
<>
<div className="final-completion group mx-auto flex min-w-[40rem] flex-col gap-3 pb-6 pt-4 md:max-w-3xl md:px-5 lg:max-w-[40rem] lg:px-1 xl:max-w-[48rem] xl:px-5">
<h1 className="text-4xl font-bold">{data.title}</h1>
<div className="border-b border-border-medium pb-6 text-base text-text-secondary">
{new Date(data.createdAt).toLocaleDateString('en-US', {
month: 'long',
day: 'numeric',
year: 'numeric',
})}
</div>
</div>
<MessagesView messagesTree={messagesTree} conversationId={data.conversationId} />
</>
);
} else {
content = (
<div className="flex h-screen items-center justify-center ">
{localize('com_ui_shared_link_not_found')}
</div>
);
}
return (
<ShareContext.Provider value={{ isSharedConvo: true }}>
<div
className="relative flex w-full grow overflow-hidden bg-white dark:bg-gray-800"
<main
className="relative flex w-full grow overflow-hidden dark:bg-surface-secondary"
style={{ paddingBottom: '50px' }}
>
<div className="transition-width relative flex h-full w-full flex-1 flex-col items-stretch overflow-hidden bg-white pt-0 dark:bg-gray-800">
<div className="flex h-full flex-col" role="presentation" tabIndex={0}>
{isLoading ? (
<div className="flex h-screen items-center justify-center">
<Spinner className="" />
</div>
) : data && messagesTree && messagesTree.length !== 0 ? (
<>
<div className="final-completion group mx-auto flex min-w-[40rem] flex-col gap-3 pb-6 pt-4 md:max-w-3xl md:px-5 lg:max-w-[40rem] lg:px-1 xl:max-w-[48rem] xl:px-5">
<h1 className="text-4xl font-bold dark:text-white">{data.title}</h1>
<div className="border-b pb-6 text-base text-gray-300">
{new Date(data.createdAt).toLocaleDateString('en-US', {
month: 'long',
day: 'numeric',
year: 'numeric',
})}
</div>
</div>
<MessagesView messagesTree={messagesTree} conversationId={data.conversationId} />
</>
) : (
<div className="flex h-screen items-center justify-center">
{localize('com_ui_shared_link_not_found')}
</div>
)}
<div className="w-full border-t-0 pl-0 pt-2 dark:border-white/20 md:w-[calc(100%-.5rem)] md:border-t-0 md:border-transparent md:pl-0 md:pt-0 md:dark:border-transparent">
<Footer className="fixed bottom-0 left-0 right-0 z-50 flex items-center justify-center gap-2 bg-gradient-to-t from-gray-50 to-transparent px-2 pb-2 pt-8 text-xs text-gray-600 dark:from-gray-800 dark:text-gray-300 md:px-[60px]" />
<div className="transition-width relative flex h-full w-full flex-1 flex-col items-stretch overflow-hidden pt-0 dark:bg-surface-secondary">
<div className="flex h-full flex-col text-text-primary" role="presentation">
{content}
<div className="w-full border-t-0 pl-0 pt-2 md:w-[calc(100%-.5rem)] md:border-t-0 md:border-transparent md:pl-0 md:pt-0 md:dark:border-transparent">
<Footer className="fixed bottom-0 left-0 right-0 z-50 flex items-center justify-center gap-2 bg-gradient-to-t from-surface-secondary to-transparent px-2 pb-2 pt-8 text-xs text-text-secondary md:px-[60px]" />
</div>
</div>
</div>
</div>
</main>
</ShareContext.Provider>
);
}