Andreas/LibreChat
1
0
Fork 0
mirror of https://github.com/danny-avila/LibreChat.git synced 2025-12-17 08:50:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

🔖 fix: URI Encoding for Bookmarks (#4172)

Browse source 
* fix: never defined AcceptTermsMutationOptions

* fix: lack of URI encoding in tag mutations
This commit is contained in:
Danny Avila 2024-09-21 09:06:02 -04:00 • committed by GitHub
parent be44caaab1
commit 44458d3832
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

6
api/server/routes/tags.js
View file

@ -61,7 +61,8 @@ router.post('/', async (req, res) => {
*/ */
router.put('/:tag', async (req, res) => { router.put('/:tag', async (req, res) => {
try { try {
const tag = await updateConversationTag(req.user.id, req.params.tag, req.body); const decodedTag = decodeURIComponent(req.params.tag);
const tag = await updateConversationTag(req.user.id, decodedTag, req.body);
if (tag) { if (tag) {
res.status(200).json(tag); res.status(200).json(tag);
} else { } else {
@ -81,7 +82,8 @@ router.put('/:tag', async (req, res) => {
*/ */
router.delete('/:tag', async (req, res) => { router.delete('/:tag', async (req, res) => {
try { try {
const tag = await deleteConversationTag(req.user.id, req.params.tag); const decodedTag = decodeURIComponent(req.params.tag);
const tag = await deleteConversationTag(req.user.id, decodedTag);
if (tag) { if (tag) {
res.status(200).json(tag); res.status(200).json(tag);
} else { } else {

2
client/src/data-provider/mutations.ts
View file

@ -863,7 +863,7 @@ export const useUpdateAssistantMutation = (
const { endpoint } = data; const { endpoint } = data;
const endpointsConfig = queryClient.getQueryData<t.TEndpointsConfig>([QueryKeys.endpoints]); const endpointsConfig = queryClient.getQueryData<t.TEndpointsConfig>([QueryKeys.endpoints]);
const endpointConfig = endpointsConfig?.[endpoint]; const endpointConfig = endpointsConfig?.[endpoint];
const version = endpointConfig.version ?? defaultAssistantsVersion[endpoint]; const version = endpointConfig?.version ?? defaultAssistantsVersion[endpoint];
return dataService.updateAssistant({ return dataService.updateAssistant({
data, data,
version, version,

3
packages/data-provider/src/api-endpoints.ts
View file

@ -208,7 +208,8 @@ export const updatePromptPermissions = (roleName: string) =>
`${roles()}/${roleName.toLowerCase()}/prompts`; `${roles()}/${roleName.toLowerCase()}/prompts`;
/* Conversation Tags */ /* Conversation Tags */
export const conversationTags = (tag?: string) => `/api/tags${tag ? `/${tag}` : ''}`; export const conversationTags = (tag?: string) =>
`/api/tags${tag != null && tag ? `/${encodeURIComponent(tag)}` : ''}`;
export const conversationTagsList = (pageNumber: string, sort?: string, order?: string) => export const conversationTagsList = (pageNumber: string, sort?: string, order?: string) =>
`${conversationTags()}/list?pageNumber=${pageNumber}${sort ? `&sort=${sort}` : ''}${ `${conversationTags()}/list?pageNumber=${pageNumber}${sort ? `&sort=${sort}` : ''}${

7
packages/data-provider/src/types/mutations.ts
View file

@ -235,3 +235,10 @@ export type UpdateConversationTagOptions = MutationOptions<
types.TConversationTagRequest types.TConversationTagRequest
>; >;
export type DeleteConversationTagOptions = MutationOptions<types.TConversationTag, string>; export type DeleteConversationTagOptions = MutationOptions<types.TConversationTag, string>;
export type AcceptTermsMutationOptions = MutationOptions<
types.TAcceptTermsResponse,
void,
unknown,
void
>;