📌 feat: Add Support for Persistable (Non-Dismissible) Banners (#10730)

* feat: Add persistable property to banners and update related components

* refactor: Clean up Banner component and improve className handling
This commit is contained in:
Marco Beretta 2025-12-03 23:22:35 +01:00 committed by GitHub
parent 997f1f6a21
commit 401b2eb217
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 42 additions and 13 deletions

View file

@ -22,15 +22,17 @@ const connect = require('./connect');
let displayTo = '';
let message = '';
let isPublic = undefined;
let persistable = undefined;
// If we have the right number of arguments, lets use them
if (process.argv.length >= 3) {
displayFrom = process.argv[2];
displayTo = process.argv[3];
message = process.argv[4];
isPublic = process.argv[5] === undefined ? undefined : process.argv[5] === 'true';
persistable = process.argv[6] === undefined ? undefined : process.argv[6] === 'true';
} else {
console.orange(
'Usage: npm run update-banner <displayFrom(Format: yyyy-mm-ddTHH:MM:SSZ)> <displayTo(Format: yyyy-mm-ddTHH:MM:SSZ)> <message> <isPublic(true/false)>',
'Usage: npm run update-banner <displayFrom(Format: yyyy-mm-ddTHH:MM:SSZ)> <displayTo(Format: yyyy-mm-ddTHH:MM:SSZ)> <message> <isPublic(true/false)> <persistable(true/false)>',
);
console.orange('Note: if you do not pass in the arguments, you will be prompted for them.');
console.purple('--------------------------');
@ -81,6 +83,11 @@ const connect = require('./connect');
isPublic = isPublicInput.toLowerCase() === 'y' ? true : false;
}
if (persistable === undefined) {
const persistableInput = await askQuestion('Is persistable (cannot be dismissed) (y/N):');
persistable = persistableInput.toLowerCase() === 'y' ? true : false;
}
// Generate the same bannerId for the same message
// This allows us to display only messages that haven't been shown yet
const NAMESPACE = '6ba7b810-9dad-11d1-80b4-00c04fd430c8'; // Use an arbitrary namespace UUID
@ -101,6 +108,7 @@ const connect = require('./connect');
message,
bannerId,
isPublic,
persistable,
},
{ new: true },
);
@ -111,6 +119,7 @@ const connect = require('./connect');
message,
bannerId,
isPublic,
persistable,
});
}
} catch (error) {
@ -131,6 +140,7 @@ const connect = require('./connect');
console.purple(`to: ${displayTo || 'not specified'}`);
console.purple(`Banner: ${message}`);
console.purple(`isPublic: ${isPublic}`);
console.purple(`persistable: ${persistable}`);
silentExit(0);
})();