From 3ef46132eb82ebd35efd8411bc19454212fbafd1 Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Mon, 25 Mar 2024 11:16:18 -0400 Subject: [PATCH] =?UTF-8?q?=F0=9F=90=9E=20fix(client):=20Prevent=20Async?= =?UTF-8?q?=20Reset=20of=20Latest=20Message=20(#2203)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit * refactor: use debug statement runStepCompleted message * fix(ChatRoute): prevent use of `newConversation` from reseting `latestMessage`, which would fire asynchronously and finalize after `latestMessage` was already correctly set --- api/server/services/Runs/StreamRunManager.js | 2 +- client/src/routes/ChatRoute.tsx | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/api/server/services/Runs/StreamRunManager.js b/api/server/services/Runs/StreamRunManager.js index 2059de6a54..072c38d27c 100644 --- a/api/server/services/Runs/StreamRunManager.js +++ b/api/server/services/Runs/StreamRunManager.js @@ -571,7 +571,7 @@ class StreamRunManager { const isMessage = step.type === StepTypes.MESSAGE_CREATION; if (isMessage) { - logger.warn('RunStep Message completion: to be handled by Message Event.', step); + logger.debug('RunStep Message completion: to be handled by Message Event.', step); return; } diff --git a/client/src/routes/ChatRoute.tsx b/client/src/routes/ChatRoute.tsx index db08888933..c43b452b25 100644 --- a/client/src/routes/ChatRoute.tsx +++ b/client/src/routes/ChatRoute.tsx @@ -65,6 +65,7 @@ export default function ChatRoute() { /* this is necessary to load all existing settings */ preset: initialConvoQuery.data as TPreset, modelsData: modelsQuery.data, + keepLatestMessage: true, }); hasSetConversation.current = !!assistants; } else if (!hasSetConversation.current && conversationId === 'new' && assistants) { @@ -75,6 +76,7 @@ export default function ChatRoute() { template: initialConvoQuery.data, preset: initialConvoQuery.data as TPreset, modelsData: modelsQuery.data, + keepLatestMessage: true, }); hasSetConversation.current = true; }