refactor: Enhance test setup and cleanup for file access control

- Introduced modelsToCleanup array to track models added during tests for proper cleanup.
- Updated afterAll hooks in test files to ensure all collections are cleared and only added models are deleted.
- Improved consistency in model initialization across test files.
- Added comments for clarity on cleanup processes and test data management.
This commit is contained in:
Danny Avila 2025-07-14 22:00:11 -04:00
parent 35c66b39c8
commit 2cf910351a
No known key found for this signature in database
GPG key ID: BF31EEB2C5CA0956
3 changed files with 67 additions and 12 deletions

View file

@ -12,6 +12,7 @@ let Agent;
let AclEntry;
let User;
let AccessRole;
let modelsToCleanup = [];
describe('File Access Control', () => {
let mongoServer;
@ -22,23 +23,39 @@ describe('File Access Control', () => {
await mongoose.connect(mongoUri);
// Initialize all models
createModels(mongoose);
const models = createModels(mongoose);
// Track which models we're adding
modelsToCleanup = Object.keys(models);
// Register models on mongoose.models so methods can access them
const models = require('~/db/models');
Object.assign(mongoose.models, models);
const dbModels = require('~/db/models');
Object.assign(mongoose.models, dbModels);
File = models.File;
Agent = models.Agent;
AclEntry = models.AclEntry;
User = models.User;
AccessRole = models.AccessRole;
File = dbModels.File;
Agent = dbModels.Agent;
AclEntry = dbModels.AclEntry;
User = dbModels.User;
AccessRole = dbModels.AccessRole;
// Seed default roles
await seedDefaultRoles();
});
afterAll(async () => {
// Clean up all collections before disconnecting
const collections = mongoose.connection.collections;
for (const key in collections) {
await collections[key].deleteMany({});
}
// Clear only the models we added
for (const modelName of modelsToCleanup) {
if (mongoose.models[modelName]) {
delete mongoose.models[modelName];
}
}
await mongoose.disconnect();
await mongoServer.stop();
});
@ -48,6 +65,7 @@ describe('File Access Control', () => {
await Agent.deleteMany({});
await AclEntry.deleteMany({});
await User.deleteMany({});
// Don't delete AccessRole as they are seeded defaults needed for tests
});
describe('hasAccessToFilesViaAgent', () => {