🔍 feat: Anthropic/Google Web Search Support via addParams / dropParams (#10456)

* feat: add support for known/add/drop parameters in Anthropic and Google LLM configurations

* ci: add tests for web search support for Anthropic and Google configurations with addParams and dropParams handling
This commit is contained in:
Danny Avila 2025-11-11 14:39:12 -05:00 committed by GitHub
parent 4685a063f5
commit 2b0fe036a8
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 521 additions and 8 deletions

View file

@ -0,0 +1,196 @@
import { getOpenAIConfig } from './config';
describe('getOpenAIConfig - Google Compatibility', () => {
describe('Google via Custom Endpoint', () => {
describe('Web Search Support via addParams', () => {
it('should enable googleSearch tool when web_search: true in addParams', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
},
customParams: {
defaultParamsEndpoint: 'google',
},
addParams: {
web_search: true,
},
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.tools).toEqual([{ googleSearch: {} }]);
expect(result.llmConfig).toMatchObject({
model: 'gemini-2.0-flash-exp',
});
});
it('should disable googleSearch tool when web_search: false in addParams', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
web_search: true, // Should be overridden by addParams
},
customParams: {
defaultParamsEndpoint: 'google',
},
addParams: {
web_search: false,
},
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.tools).toEqual([]);
});
it('should disable googleSearch when in dropParams', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
web_search: true,
},
customParams: {
defaultParamsEndpoint: 'google',
},
dropParams: ['web_search'],
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.tools).toEqual([]);
});
it('should handle web_search with mixed Google and OpenAI params in addParams', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
},
customParams: {
defaultParamsEndpoint: 'google',
},
addParams: {
web_search: true,
temperature: 0.8, // Shared param (both Google and OpenAI)
topK: 40, // Google-only param, goes to modelKwargs
frequencyPenalty: 0.5, // Known OpenAI param, goes to top level
customUnknown: 'test', // Unknown param, goes to modelKwargs
},
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.tools).toEqual([{ googleSearch: {} }]);
expect(result.llmConfig.temperature).toBe(0.8); // Shared param at top level
expect(result.llmConfig.frequencyPenalty).toBe(0.5); // Known OpenAI param at top level
expect(result.llmConfig.modelKwargs).toMatchObject({
topK: 40, // Google-specific in modelKwargs
customUnknown: 'test', // Unknown param in modelKwargs
});
});
it('should handle Google native params in addParams without web_search', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
},
customParams: {
defaultParamsEndpoint: 'google',
},
addParams: {
temperature: 0.9, // Shared param (both Google and OpenAI)
topP: 0.95, // Shared param (both Google and OpenAI)
topK: 50, // Google-only, goes to modelKwargs
maxOutputTokens: 8192, // Google-only, goes to modelKwargs
},
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.llmConfig).toMatchObject({
model: 'gemini-2.0-flash-exp',
temperature: 0.9, // Shared params at top level
topP: 0.95,
});
expect(result.llmConfig.modelKwargs).toMatchObject({
topK: 50, // Google-specific in modelKwargs
maxOutputTokens: 8192,
});
expect(result.tools).toEqual([]);
});
it('should drop Google native params with dropParams', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
temperature: 0.7,
topK: 40,
topP: 0.9,
},
customParams: {
defaultParamsEndpoint: 'google',
},
dropParams: ['topK', 'topP'],
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.llmConfig.temperature).toBe(0.7);
expect((result.llmConfig as Record<string, unknown>).topK).toBeUndefined();
expect(result.llmConfig.topP).toBeUndefined();
});
it('should handle both addParams and dropParams for Google', () => {
const apiKey = JSON.stringify({ GOOGLE_API_KEY: 'test-google-key' });
const endpoint = 'Gemini (Custom)';
const options = {
modelOptions: {
model: 'gemini-2.0-flash-exp',
topK: 30, // Will be dropped
},
customParams: {
defaultParamsEndpoint: 'google',
},
addParams: {
web_search: true,
temperature: 0.8, // Shared param
maxOutputTokens: 4096, // Google-only param
},
dropParams: ['topK'],
reverseProxyUrl: 'https://generativelanguage.googleapis.com/v1beta/openai',
};
const result = getOpenAIConfig(apiKey, options, endpoint);
expect(result.tools).toEqual([{ googleSearch: {} }]);
expect(result.llmConfig).toMatchObject({
model: 'gemini-2.0-flash-exp',
temperature: 0.8,
});
expect(result.llmConfig.modelKwargs).toMatchObject({
maxOutputTokens: 4096, // Google-specific in modelKwargs
});
expect((result.llmConfig as Record<string, unknown>).topK).toBeUndefined();
// Verify topK is not in modelKwargs either
expect(result.llmConfig.modelKwargs?.topK).toBeUndefined();
});
});
});
});