From 28bdd0dfa696af77da42471a105bc1308f274b6c Mon Sep 17 00:00:00 2001 From: Danny Avila Date: Tue, 2 Dec 2025 09:48:41 -0500 Subject: [PATCH] =?UTF-8?q?=F0=9F=A7=8A=20refactor:=20`iconURL`=20Handling?= =?UTF-8?q?=20in=20Submission=20Flow=20(#10772)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Updated `useChatFunctions` to derive `iconURL` from conversation data before parsing - Modified `parseCompactConvo` to explicitly omit `iconURL` from parsed conversations, reinforcing security measures around URL handling. --- client/src/hooks/Chat/useChatFunctions.ts | 3 ++- packages/data-provider/src/parsers.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/client/src/hooks/Chat/useChatFunctions.ts b/client/src/hooks/Chat/useChatFunctions.ts index 114a6376a6..8a61cd91c1 100644 --- a/client/src/hooks/Chat/useChatFunctions.ts +++ b/client/src/hooks/Chat/useChatFunctions.ts @@ -168,6 +168,7 @@ export default function useChatFunctions({ const endpointsConfig = queryClient.getQueryData([QueryKeys.endpoints]); const endpointType = getEndpointField(endpointsConfig, endpoint, 'type'); + const iconURL = conversation?.iconURL; /** This becomes part of the `endpointOption` */ const convo = parseCompactConvo({ @@ -248,9 +249,9 @@ export default function useChatFunctions({ conversationId, unfinished: false, isCreatedByUser: false, - iconURL: convo?.iconURL, model: convo?.model, error: false, + iconURL, }; if (isAssistantsEndpoint(endpoint)) { diff --git a/packages/data-provider/src/parsers.ts b/packages/data-provider/src/parsers.ts index be8d6dcde0..c4fea469ee 100644 --- a/packages/data-provider/src/parsers.ts +++ b/packages/data-provider/src/parsers.ts @@ -326,7 +326,7 @@ export const parseCompactConvo = ({ possibleValues?: TPossibleValues; // TODO: POC for default schema // defaultSchema?: Partial, -}) => { +}): Omit | null => { if (!endpoint) { throw new Error(`undefined endpoint: ${endpoint}`); }