feat: first pass, sharing agents

This commit is contained in:
Danny Avila 2024-09-04 15:29:14 -04:00
parent 0a73caf1d8
commit 1bc0689134
No known key found for this signature in database
GPG key ID: 2DD9CC89B9B50364
8 changed files with 241 additions and 22 deletions

View file

@ -31,18 +31,17 @@ const createAgent = async (agentData) => {
const getAgent = async (searchParameter) => await Agent.findOne(searchParameter).lean();
/**
* Update an agent with new data without overwriting existing properties,
* or create a new agent if it doesn't exist, within a transaction session if provided.
* Update an agent with new data without overwriting existing
* properties, or create a new agent if it doesn't exist.
*
* @param {Object} searchParameter - The search parameters to find the agent to update.
* @param {string} searchParameter.id - The ID of the agent to update.
* @param {string} searchParameter.author - The user ID of the agent's author.
* @param {string} [searchParameter.author] - The user ID of the agent's author.
* @param {Object} updateData - An object containing the properties to update.
* @param {mongoose.ClientSession} [session] - The transaction session to use (optional).
* @returns {Promise<Agent>} The updated or newly created agent document as a plain object.
*/
const updateAgent = async (searchParameter, updateData, session = null) => {
const options = { new: true, upsert: true, session };
const updateAgent = async (searchParameter, updateData) => {
const options = { new: true, upsert: true };
return await Agent.findOneAndUpdate(searchParameter, updateData, options).lean();
};
@ -51,7 +50,7 @@ const updateAgent = async (searchParameter, updateData, session = null) => {
*
* @param {Object} searchParameter - The search parameters to find the agent to delete.
* @param {string} searchParameter.id - The ID of the agent to delete.
* @param {string} searchParameter.author - The user ID of the agent's author.
* @param {string} [searchParameter.author] - The user ID of the agent's author.
* @returns {Promise<void>} Resolves when the agent has been successfully deleted.
*/
const deleteAgent = async (searchParameter) => {
@ -126,10 +125,10 @@ const updateAgentProjects = async (agentId, projectIds, removeProjectIds) => {
}
if (Object.keys(updateOps).length === 0) {
return await Agent.findById(agentId).lean();
return await getAgent({ id: agentId });
}
return await Agent.findByIdAndUpdate(agentId, updateOps, { new: true, lean: true });
return await updateAgent({ id: agentId }, updateOps);
};
module.exports = {

View file

@ -101,10 +101,13 @@ const updateAgentHandler = async (req, res) => {
const id = req.params.id;
const { projectIds, removeProjectIds, ...updateData } = req.body;
const updatedAgent = await updateAgent({ id, author: req.user.id }, updateData);
let updatedAgent;
if (Object.keys(updateData).length > 0) {
updatedAgent = await updateAgent({ id, author: req.user.id }, updateData);
}
if (projectIds || removeProjectIds) {
await updateAgentProjects(id, projectIds, removeProjectIds);
updatedAgent = await updateAgentProjects(id, projectIds, removeProjectIds);
}
return res.json(updatedAgent);

View file

@ -14,6 +14,7 @@ import { useToastContext } from '~/Providers';
import { Spinner } from '~/components/svg';
import DeleteButton from './DeleteButton';
import AgentAvatar from './AgentAvatar';
import ShareAgent from './ShareAgent';
import AgentTool from './AgentTool';
import { Panel } from '~/common';
@ -190,7 +191,7 @@ export default function AgentConfig({
name="id"
control={control}
render={({ field }) => (
<p className="h-3 text-xs italic text-gray-600" aria-live="polite">
<p className="h-3 text-xs italic text-text-secondary" aria-live="polite">
{field.value}
</p>
)}
@ -343,6 +344,11 @@ export default function AgentConfig({
setCurrentAgentId={setCurrentAgentId}
createMutation={create}
/>
<ShareAgent
agent_id={agent_id}
agentName={agent?.name ?? ''}
projectIds={agent?.projectIds ?? []}
/>
{/* Submit Button */}
<button
className="btn btn-primary focus:shadow-outline flex w-full items-center justify-center px-4 py-2 font-semibold text-white hover:bg-green-600 focus:border-green-500"

View file

@ -16,7 +16,7 @@ const keys = new Set(Object.keys(defaultAgentFormValues));
export default function AgentSelect({
reset,
value: currentAgentValue,
selectedAgentId,
selectedAgentId = null,
setCurrentAgentId,
createMutation,
}: {
@ -31,12 +31,12 @@ export default function AgentSelect({
// const fileMap = useFileMapContext();
const lastSelectedAgent = useRef<string | null>(null);
const { data: agents = [] } = useListAgentsQuery(undefined, {
const { data: agents = null } = useListAgentsQuery(undefined, {
select: (res) => res.data.map((agent) => processAgentOption(agent /*, fileMap */)),
});
const agentQuery = useGetAgentByIdQuery(selectedAgentId ?? '', {
enabled: !!selectedAgentId,
enabled: !!(selectedAgentId ?? ''),
});
const resetAgentForm = useCallback(
@ -45,7 +45,7 @@ export default function AgentSelect({
...fullAgent,
provider: createProviderOption(fullAgent.provider),
label: fullAgent.name ?? '',
value: fullAgent.id ?? '',
value: fullAgent.id || '',
};
const actions: AgentCapabilities = {
@ -84,7 +84,7 @@ export default function AgentSelect({
const onSelect = useCallback(
(selectedId: string) => {
const agentExists = !!(selectedId
? agents.find((agent) => agent.id === selectedId)
? (agents ?? []).find((agent) => agent.id === selectedId)
: undefined);
createMutation.reset();
@ -120,7 +120,7 @@ export default function AgentSelect({
return;
}
if (selectedAgentId && agents) {
if (selectedAgentId != null && selectedAgentId !== '' && agents) {
timerId = setTimeout(() => {
lastSelectedAgent.current = selectedAgentId;
onSelect(selectedAgentId);
@ -136,8 +136,8 @@ export default function AgentSelect({
const createAgent = localize('com_ui_create') + ' ' + localize('com_ui_agent');
const hasAgentValue = !!(typeof currentAgentValue === 'object'
? currentAgentValue.value
: currentAgentValue);
? currentAgentValue.value != null && currentAgentValue.value !== ''
: typeof currentAgentValue !== 'undefined');
return (
<SelectDropDown
value={!hasAgentValue ? createAgent : (currentAgentValue as TAgentOption)}

View file

@ -78,6 +78,7 @@ export default function DeleteButton({
'btn btn-neutral border-token-border-light relative h-9 rounded-lg font-medium',
removeFocusOutlines,
)}
aria-label={localize('com_ui_delete') + ' ' + localize('com_ui_agent')}
type="button"
>
<div className="flex w-full items-center justify-center gap-2 text-red-500">

View file

@ -0,0 +1,206 @@
import React, { useEffect, useMemo } from 'react';
import { Share2Icon } from 'lucide-react';
import { useForm, Controller } from 'react-hook-form';
import { Permissions } from 'librechat-data-provider';
import { useGetStartupConfig } from 'librechat-data-provider/react-query';
import type { TStartupConfig, AgentUpdateParams } from 'librechat-data-provider';
import {
Switch,
OGDialog,
OGDialogTitle,
OGDialogClose,
OGDialogContent,
OGDialogTrigger,
} from '~/components/ui';
import { useUpdateAgentMutation } from '~/data-provider';
import { cn, removeFocusOutlines } from '~/utils';
import { useToastContext } from '~/Providers';
import { useLocalize } from '~/hooks';
type FormValues = {
[Permissions.SHARED_GLOBAL]: boolean;
};
export default function ShareAgent({
agent_id = '',
agentName,
projectIds = [],
}: {
agent_id?: string;
agentName?: string;
projectIds?: string[];
}) {
const localize = useLocalize();
const { showToast } = useToastContext();
const { data: startupConfig = {} as TStartupConfig, isFetching } = useGetStartupConfig();
const { instanceProjectId } = startupConfig;
const agentIsGlobal = useMemo(
() => !!projectIds.includes(instanceProjectId),
[projectIds, instanceProjectId],
);
const {
control,
setValue,
getValues,
handleSubmit,
formState: { isSubmitting },
} = useForm<FormValues>({
mode: 'onChange',
defaultValues: {
[Permissions.SHARED_GLOBAL]: agentIsGlobal,
},
});
useEffect(() => {
setValue(Permissions.SHARED_GLOBAL, agentIsGlobal);
}, [agentIsGlobal, setValue]);
const updateAgent = useUpdateAgentMutation({
onSuccess: (data) => {
showToast({
message: `${localize('com_assistants_update_success')} ${
data.name ?? localize('com_ui_agent')
}`,
status: 'success',
});
},
onError: (err) => {
const error = err as Error;
showToast({
message: `${localize('com_agents_update_error')}${
error.message ? ` ${localize('com_ui_error')}: ${error.message}` : ''
}`,
status: 'error',
});
},
});
if (!agent_id || !instanceProjectId) {
return null;
}
const onSubmit = (data: FormValues) => {
if (!agent_id || !instanceProjectId) {
return;
}
const payload = {} as AgentUpdateParams;
if (data[Permissions.SHARED_GLOBAL]) {
payload.projectIds = [startupConfig.instanceProjectId];
} else {
payload.removeProjectIds = [startupConfig.instanceProjectId];
}
updateAgent.mutate({
agent_id,
data: payload,
});
};
return (
<OGDialog>
<OGDialogTrigger asChild>
<button
className={cn(
'btn btn-neutral border-token-border-light relative h-9 rounded-lg font-medium',
removeFocusOutlines,
)}
aria-label={localize(
'com_ui_share_var',
agentName != null && agentName !== '' ? `"${agentName}"` : localize('com_ui_agent'),
)}
type="button"
>
<div className="flex w-full items-center justify-center gap-2 text-blue-500">
<Share2Icon className="icon-md h-4 w-4" />
</div>
</button>
</OGDialogTrigger>
<OGDialogContent className="border-border-light bg-surface-primary-alt text-text-secondary">
<OGDialogTitle>
{localize(
'com_ui_share_var',
agentName != null && agentName !== '' ? `"${agentName}"` : localize('com_ui_agent'),
)}
</OGDialogTitle>
<form
className="p-2"
onSubmit={(e) => {
e.preventDefault();
e.stopPropagation();
handleSubmit(onSubmit)(e);
}}
>
<div className="mb-4 flex items-center justify-between gap-2 py-4">
<div className="flex items-center">
<button
type="button"
className="mr-2 cursor-pointer"
onClick={() =>
setValue(Permissions.SHARED_GLOBAL, !getValues(Permissions.SHARED_GLOBAL), {
shouldDirty: true,
})
}
onKeyDown={(e) => {
if (e.key === 'Enter' || e.key === ' ') {
e.preventDefault();
setValue(Permissions.SHARED_GLOBAL, !getValues(Permissions.SHARED_GLOBAL), {
shouldDirty: true,
});
}
}}
aria-checked={getValues(Permissions.SHARED_GLOBAL)}
role="checkbox"
>
{localize('com_ui_share_to_all_users')}
</button>
<label htmlFor={Permissions.SHARED_GLOBAL} className="select-none">
{agentIsGlobal && (
<span className="ml-2 text-xs">{localize('com_ui_agent_shared_to_all')}</span>
)}
</label>
</div>
<Controller
name={Permissions.SHARED_GLOBAL}
control={control}
disabled={isFetching || updateAgent.isLoading || !instanceProjectId}
rules={{
validate: (value) => {
const isValid = !(value && agentIsGlobal);
if (!isValid) {
showToast({
message: localize('com_ui_agent_already_shared_to_all'),
status: 'warning',
});
}
return isValid;
},
}}
render={({ field }) => (
<Switch
{...field}
checked={field.value}
onCheckedChange={field.onChange}
value={field.value.toString()}
/>
)}
/>
</div>
<div className="flex justify-end">
<OGDialogClose asChild>
<button
type="submit"
disabled={isSubmitting || isFetching}
className="btn rounded bg-green-500 font-bold text-white transition-all hover:bg-green-600"
>
{localize('com_ui_save')}
</button>
</OGDialogClose>
</div>
</form>
</OGDialogContent>
</OGDialog>
);
}

View file

@ -90,6 +90,7 @@ export const defaultAgentFormValues = {
model_parameters: {},
tools: [],
provider: {},
projectIds: [],
code_interpreter: false,
image_vision: false,
retrieval: false,

View file

@ -160,6 +160,7 @@ export type Agent = {
file_ids: string[];
instructions: string | null;
tools?: string[];
projectIds?: string[];
tool_kwargs?: Record<string, unknown>;
tool_resources?: ToolResources;
metadata?: Record<string, unknown>;
@ -192,8 +193,10 @@ export type AgentUpdateParams = {
tools?: Array<FunctionTool | string>;
tool_resources?: ToolResources;
provider?: AgentProvider;
model: string | null;
model_parameters: AgentModelParameters;
model?: string | null;
model_parameters?: AgentModelParameters;
projectIds?: string[];
removeProjectIds?: string[];
};
export type AgentListParams = {