feat: utitlize lean queries, remove migration script, index createdAt timestamps (#698)

* feat(mongoDb): utitlize lean queries and index createdAt timestamps for cosmosDB support

* fix: remove unnecessary lean() method from deleteMany calls

* fix: remove unnecessary lean() method from deleteMany calls

* fix: remove lean() from queries that need hydration

* chore(migrateDb.js): remove unused migration script
fix(Preset.js): return lean documents when retrieving presets
refactor(index.js): remove migration script from server initialization
refactor(convos.js): remove toObject() when sending conversation object
refactor(presets.js): remove toObject() when sending presets object
This commit is contained in:
Danny Avila 2023-07-25 19:27:55 -04:00 committed by GitHub
parent 2f7658e39f
commit 19af2b06ce
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
13 changed files with 34 additions and 160 deletions

View file

@ -55,7 +55,7 @@ configSchema.methods.incrementCount = function () {
// Static methods
configSchema.statics.findByTag = async function (tag) {
return await this.findOne({ tag });
return await this.findOne({ tag }).lean();
};
configSchema.statics.updateByTag = async function (tag, update) {
@ -67,7 +67,7 @@ const Config = mongoose.models.Config || mongoose.model('Config', configSchema);
module.exports = {
getConfigs: async (filter) => {
try {
return await Config.find(filter).exec();
return await Config.find(filter).lean();
} catch (error) {
console.error(error);
return { config: 'Error getting configs' };
@ -75,7 +75,7 @@ module.exports = {
},
deleteConfigs: async (filter) => {
try {
return await Config.deleteMany(filter).exec();
return await Config.deleteMany(filter);
} catch (error) {
console.error(error);
return { config: 'Error deleting configs' };

View file

@ -4,7 +4,7 @@ const { getMessages, deleteMessages } = require('./Message');
const getConvo = async (user, conversationId) => {
try {
return await Conversation.findOne({ user, conversationId }).exec();
return await Conversation.findOne({ user, conversationId }).lean();
} catch (error) {
console.log(error);
return { message: 'Error getting single conversation' };
@ -24,7 +24,7 @@ module.exports = {
return await Conversation.findOneAndUpdate({ conversationId: conversationId, user }, update, {
new: true,
upsert: true,
}).exec();
});
} catch (error) {
console.log(error);
return { message: 'Error saving conversation' };
@ -35,10 +35,10 @@ module.exports = {
const totalConvos = (await Conversation.countDocuments({ user })) || 1;
const totalPages = Math.ceil(totalConvos / pageSize);
const convos = await Conversation.find({ user })
.sort({ createdAt: -1, created: -1 })
.sort({ createdAt: -1 })
.skip((pageNumber - 1) * pageSize)
.limit(pageSize)
.exec();
.lean();
return { conversations: convos, pages: totalPages, pageNumber, pageSize };
} catch (error) {
console.log(error);
@ -62,7 +62,7 @@ module.exports = {
Conversation.findOne({
user,
conversationId: convo.conversationId,
}).exec(),
}).lean(),
),
);
@ -121,7 +121,7 @@ module.exports = {
deleteConvos: async (user, filter) => {
let toRemove = await Conversation.find({ ...filter, user }).select('conversationId');
const ids = toRemove.map((instance) => instance.conversationId);
let deleteCount = await Conversation.deleteMany({ ...filter, user }).exec();
let deleteCount = await Conversation.deleteMany({ ...filter, user });
deleteCount.messages = await deleteMessages({ conversationId: { $in: ids } });
return deleteCount;
},

View file

@ -78,12 +78,12 @@ module.exports = {
},
async deleteMessagesSince({ messageId, conversationId }) {
try {
const message = await Message.findOne({ messageId }).exec();
const message = await Message.findOne({ messageId }).lean();
if (message) {
return await Message.find({ conversationId })
.deleteMany({ createdAt: { $gt: message.createdAt } })
.exec();
return await Message.find({ conversationId }).deleteMany({
createdAt: { $gt: message.createdAt },
});
}
} catch (err) {
console.error(`Error deleting messages: ${err}`);
@ -93,7 +93,7 @@ module.exports = {
async getMessages(filter) {
try {
return await Message.find(filter).sort({ createdAt: 1 }).exec();
return await Message.find(filter).sort({ createdAt: 1 }).lean();
} catch (err) {
console.error(`Error getting messages: ${err}`);
throw new Error('Failed to get messages.');
@ -102,7 +102,7 @@ module.exports = {
async deleteMessages(filter) {
try {
return await Message.deleteMany(filter).exec();
return await Message.deleteMany(filter);
} catch (err) {
console.error(`Error deleting messages: ${err}`);
throw new Error('Failed to delete messages.');

View file

@ -2,7 +2,7 @@ const Preset = require('./schema/presetSchema');
const getPreset = async (user, presetId) => {
try {
return await Preset.findOne({ user, presetId }).exec();
return await Preset.findOne({ user, presetId }).lean();
} catch (error) {
console.log(error);
return { message: 'Error getting single preset' };
@ -14,10 +14,10 @@ module.exports = {
getPreset,
getPresets: async (user, filter) => {
try {
return await Preset.find({ ...filter, user }).exec();
return await Preset.find({ ...filter, user }).lean();
} catch (error) {
console.log(error);
return { message: 'Error retriving presets' };
return { message: 'Error retrieving presets' };
}
},
savePreset: async (user, { presetId, newPresetId, ...preset }) => {
@ -31,7 +31,7 @@ module.exports = {
{ presetId, user },
{ $set: update },
{ new: true, upsert: true },
).exec();
);
} catch (error) {
console.log(error);
return { message: 'Error saving preset' };
@ -40,7 +40,7 @@ module.exports = {
deletePresets: async (user, filter) => {
// let toRemove = await Preset.find({ ...filter, user }).select('presetId');
// const ids = toRemove.map((instance) => instance.presetId);
let deleteCount = await Preset.deleteMany({ ...filter, user }).exec();
let deleteCount = await Preset.deleteMany({ ...filter, user });
return deleteCount;
},
};

View file

@ -34,7 +34,7 @@ module.exports = {
},
getPrompts: async (filter) => {
try {
return await Prompt.find(filter).exec();
return await Prompt.find(filter).lean();
} catch (error) {
console.error(error);
return { prompt: 'Error getting prompts' };
@ -42,7 +42,7 @@ module.exports = {
},
deletePrompts: async (filter) => {
try {
return await Prompt.deleteMany(filter).exec();
return await Prompt.deleteMany(filter);
} catch (error) {
console.error(error);
return { prompt: 'Error deleting prompts' };

View file

@ -61,6 +61,8 @@ if (process.env.MEILI_HOST && process.env.MEILI_MASTER_KEY) {
});
}
convoSchema.index({ createdAt: 1 });
const Conversation = mongoose.models.Conversation || mongoose.model('Conversation', convoSchema);
module.exports = Conversation;

View file

@ -100,6 +100,8 @@ if (process.env.MEILI_HOST && process.env.MEILI_MASTER_KEY) {
});
}
messageSchema.index({ createdAt: 1 });
const Message = mongoose.models.Message || mongoose.model('Message', messageSchema);
module.exports = Message;