🔇 fix: Hide Button Icons from Screen Readers (#10776)

If you've got a screen reader that is reading out the whole page,
each icon button (i.e., `<button><SVG></button>`) will have both
the button's aria-label read out as well as the title from the
SVG (which is usually just "image").

Since we are pretty good about setting aria-labels, we should instead
use `aria-hidden="true"` on these images, since they are not useful
to be read out.

I don't consider this a comprehensive review of all icons in the app,
but I knocked out all the low hanging fruit in this commit.

packages/client/src/components/ThemeSelector.tsx

@@ -12,9 +12,9 @@ type ThemeType = 'system' | 'dark' | 'light';
 
 const Theme = ({ theme, onChange }: { theme: string; onChange: (value: string) => void }) => {
   const themeIcons: Record<ThemeType, JSX.Element> = {
-    system: <Monitor />,
-    dark: <Moon color="white" />,
-    light: <Sun />,
+    system: <Monitor aria-hidden="true" />,
+    dark: <Moon color="white" aria-hidden="true" />,
+    light: <Sun aria-hidden="true" />,
   };
 
   const nextTheme = isDark(theme) ? 'light' : 'dark';