🔇 fix: Hide Button Icons from Screen Readers (#10776)

If you've got a screen reader that is reading out the whole page,
each icon button (i.e., `<button><SVG></button>`) will have both
the button's aria-label read out as well as the title from the
SVG (which is usually just "image").

Since we are pretty good about setting aria-labels, we should instead
use `aria-hidden="true"` on these images, since they are not useful
to be read out.

I don't consider this a comprehensive review of all icons in the app,
but I knocked out all the low hanging fruit in this commit.

client/src/components/Sharing/PeoplePicker/SearchPicker.tsx

@@ -85,7 +85,10 @@ export function SearchPicker<TOption extends { key: string; value: string }>({
           {isLoading ? (
             <Spinner className="absolute left-3 h-4 w-4" />
           ) : (
-            <Search className="absolute left-3 h-4 w-4 text-text-secondary group-focus-within:text-text-primary group-hover:text-text-primary" />
+            <Search
+              className="absolute left-3 h-4 w-4 text-text-secondary group-focus-within:text-text-primary group-hover:text-text-primary"
+              aria-hidden="true"
+            />
           )}
           <Ariakit.Combobox
             ref={inputRef}