🔇 fix: Hide Button Icons from Screen Readers (#10776)

If you've got a screen reader that is reading out the whole page,
each icon button (i.e., `<button><SVG></button>`) will have both
the button's aria-label read out as well as the title from the
SVG (which is usually just "image").

Since we are pretty good about setting aria-labels, we should instead
use `aria-hidden="true"` on these images, since they are not useful
to be read out.

I don't consider this a comprehensive review of all icons in the app,
but I knocked out all the low hanging fruit in this commit.

client/src/components/MCP/MCPConfigDialog.tsx

@@ -65,14 +65,14 @@ export default function MCPConfigDialog({
       if (requiresOAuth) {
         return (
           <div className="flex items-center gap-2 rounded-full bg-amber-50 px-2 py-0.5 text-xs font-medium text-amber-600 dark:bg-amber-950 dark:text-amber-400">
-            <KeyRound className="h-3 w-3" />
+            <KeyRound className="h-3 w-3" aria-hidden="true" />
             <span>{localize('com_ui_oauth')}</span>
           </div>
         );
       } else {
         return (
           <div className="flex items-center gap-2 rounded-full bg-orange-50 px-2 py-0.5 text-xs font-medium text-orange-600 dark:bg-orange-950 dark:text-orange-400">
-            <PlugZap className="h-3 w-3" />
+            <PlugZap className="h-3 w-3" aria-hidden="true" />
             <span>{localize('com_ui_offline')}</span>
           </div>
         );
@@ -82,7 +82,7 @@ export default function MCPConfigDialog({
     if (connectionState === 'error') {
       return (
         <div className="flex items-center gap-2 rounded-full bg-red-50 px-2 py-0.5 text-xs font-medium text-red-600 dark:bg-red-950 dark:text-red-400">
-          <AlertTriangle className="h-3 w-3" />
+          <AlertTriangle className="h-3 w-3" aria-hidden="true" />
           <span>{localize('com_ui_error')}</span>
         </div>
       );

client/src/components/MCP/MCPServerStatusIcon.tsx

@@ -138,7 +138,7 @@ function DisconnectedOAuthStatusIcon({ serverName, onConfigClick }: StatusIconPr
       className="flex h-6 w-6 items-center justify-center rounded p-1 hover:bg-surface-secondary"
       aria-label={localize('com_nav_mcp_configure_server', { 0: serverName })}
     >
-      <KeyRound className="h-4 w-4 text-amber-500" />
+      <KeyRound className="h-4 w-4 text-amber-500" aria-hidden="true" />
     </button>
   );
 }
@@ -151,7 +151,7 @@ function DisconnectedStatusIcon({ serverName, onConfigClick }: StatusIconProps)
       className="flex h-6 w-6 items-center justify-center rounded p-1 hover:bg-surface-secondary"
       aria-label={localize('com_nav_mcp_configure_server', { 0: serverName })}
     >
-      <PlugZap className="h-4 w-4 text-orange-500" />
+      <PlugZap className="h-4 w-4 text-orange-500" aria-hidden="true" />
     </button>
   );
 }
@@ -164,7 +164,7 @@ function ErrorStatusIcon({ serverName, onConfigClick }: StatusIconProps) {
       className="flex h-6 w-6 items-center justify-center rounded p-1 hover:bg-surface-secondary"
       aria-label={localize('com_nav_mcp_configure_server', { 0: serverName })}
     >
-      <AlertTriangle className="h-4 w-4 text-red-500" />
+      <AlertTriangle className="h-4 w-4 text-red-500" aria-hidden="true" />
     </button>
   );
 }
@@ -185,7 +185,10 @@ function AuthenticatedStatusIcon({
       className="flex h-6 w-6 items-center justify-center rounded p-1 hover:bg-surface-secondary"
       aria-label={localize('com_nav_mcp_configure_server', { 0: serverName })}
     >
-      <SettingsIcon className={`h-4 w-4 ${isAuthenticated ? 'text-green-500' : 'text-gray-400'}`} />
+      <SettingsIcon
+        className={`h-4 w-4 ${isAuthenticated ? 'text-green-500' : 'text-gray-400'}`}
+        aria-hidden="true"
+      />
     </button>
   );
 }

client/src/components/MCP/ServerInitializationSection.tsx

@@ -85,7 +85,7 @@ export default function ServerInitializationSection({
   const icon = isServerInitializing ? (
     <Spinner className="h-4 w-4" />
   ) : (
-    <RefreshCw className="h-4 w-4" />
+    <RefreshCw className="h-4 w-4" aria-hidden="true" />
   );
 
   return (