🔇 fix: Hide Button Icons from Screen Readers (#10776)

If you've got a screen reader that is reading out the whole page,
each icon button (i.e., `<button><SVG></button>`) will have both
the button's aria-label read out as well as the title from the
SVG (which is usually just "image").

Since we are pretty good about setting aria-labels, we should instead
use `aria-hidden="true"` on these images, since they are not useful
to be read out.

I don't consider this a comprehensive review of all icons in the app,
but I knocked out all the low hanging fruit in this commit.

client/src/components/Artifacts/Artifacts.tsx

@@ -257,7 +257,11 @@ export default function Artifacts() {
                   {isRefreshing ? (
                     <Spinner size={16} />
                   ) : (
-                    <RefreshCw size={16} className="transition-transform duration-200" />
+                    <RefreshCw
+                      size={16}
+                      className="transition-transform duration-200"
+                      aria-hidden="true"
+                    />
                   )}
                 </Button>
               )}
@@ -284,7 +288,7 @@ export default function Artifacts() {
                 onClick={closeArtifacts}
                 aria-label={localize('com_ui_close')}
               >
-                <X size={16} />
+                <X size={16} aria-hidden="true" />
               </Button>
             </div>
           </div>

client/src/components/Artifacts/Code.tsx

@@ -114,7 +114,11 @@ export const CopyCodeButton: React.FC<{ content: string }> = ({ content }) => {
       onClick={handleCopy}
       aria-label={isCopied ? localize('com_ui_copied') : localize('com_ui_copy_code')}
     >
-      {isCopied ? <CircleCheckBig size={16} /> : <Copy size={16} />}
+      {isCopied ? (
+        <CircleCheckBig size={16} aria-hidden="true" />
+      ) : (
+        <Copy size={16} aria-hidden="true" />
+      )}
     </Button>
   );
 };

client/src/components/Artifacts/DownloadArtifact.tsx

@@ -41,7 +41,11 @@ const DownloadArtifact = ({ artifact }: { artifact: Artifact }) => {
       onClick={handleDownload}
       aria-label={localize('com_ui_download_artifact')}
     >
-      {isDownloaded ? <CircleCheckBig size={16} /> : <Download size={16} />}
+      {isDownloaded ? (
+        <CircleCheckBig size={16} aria-hidden="true" />
+      ) : (
+        <Download size={16} aria-hidden="true" />
+      )}
     </Button>
   );
 };