🛣️ fix: Remove Title Tokens Limit for GPT-5 Models (#8948)

* 🛣️ fix: Remove Title Tokens Limit for GPT-5 Models

* 🛣️ fix: Remove max_completion_tokens from modelKwargs when maxTokens is disabled

* chore: Add test-image* to .gitignore for CI/CD data
This commit is contained in:
Danny Avila 2025-08-08 11:15:29 -04:00 committed by GitHub
parent 7147bce3c3
commit 0939250f07
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 9 additions and 9 deletions

3
.gitignore vendored
View file

@ -13,6 +13,9 @@ pids
*.seed *.seed
.git .git
# CI/CD data
test-image*
# Directory for instrumented libs generated by jscoverage/JSCover # Directory for instrumented libs generated by jscoverage/JSCover
lib-cov lib-cov

View file

@ -1122,17 +1122,14 @@ class AgentClient extends BaseClient {
clientOptions.configuration = options.configOptions; clientOptions.configuration = options.configOptions;
} }
// Ensure maxTokens is set for non-o1 models const shouldRemoveMaxTokens = /\b(o\d|gpt-[5-9])\b/i.test(clientOptions.model);
if (!/\b(o\d)\b/i.test(clientOptions.model) && !clientOptions.maxTokens) { if (shouldRemoveMaxTokens && clientOptions.maxTokens != null) {
delete clientOptions.maxTokens;
} else if (!shouldRemoveMaxTokens && !clientOptions.maxTokens) {
clientOptions.maxTokens = 75; clientOptions.maxTokens = 75;
} else if (/\b(o\d)\b/i.test(clientOptions.model) && clientOptions.maxTokens != null) {
delete clientOptions.maxTokens;
} }
if (shouldRemoveMaxTokens && clientOptions?.modelKwargs?.max_completion_tokens != null) {
if (/\bgpt-[5-9]\b/i.test(clientOptions.model) && clientOptions.maxTokens != null) { delete clientOptions.modelKwargs.max_completion_tokens;
clientOptions.modelKwargs = clientOptions.modelKwargs ?? {};
clientOptions.modelKwargs.max_completion_tokens = clientOptions.maxTokens;
delete clientOptions.maxTokens;
} }
clientOptions = Object.assign( clientOptions = Object.assign(