🏷️ fix: Address Statefulness Issues for Bookmarks (#3590)

* refactor: optimize tag methods, remove rebuild

* refactor(tags): add lean db operations, fix updateTagsForConversation, remove rebuild button, only send convoId once

* refactor: Update BookmarkMenu to use Constants.NEW_CONVO constant for comparison

* style: Update BookmarkMenu styles and constants, use theming

* refactor: move tags query from package to client workspace

* refactor: optimize ConversationTag document creation and update logic

* style: Update BookmarkMenuItems to use theming

* refactor: JSDocs + try/catch for conversation tags API routes

* refactor: Update BookmarkNav theming classes and new data provider location

* fix: statefulness of conversation bookmarks
- move non-mutation hook to hooks/Conversation
- remove use of deprecated global convo
- update convo infinite data as well as current convo state upon successful tag add

* refactor: Update BookmarkMenu styles and constants, use theming

* refactor: Add lean option to ConversationTag deletion query

* fix(BookmarkTable): position order rendering esp. when new tag is created

* refactor: Update useBookmarkSucess to useBookmarkSuccess for consistency

* refactor: Update ConversationTag creation logic to increment count only if addToConversation is true

* style: theming

client/src/components/Bookmarks/BookmarkForm.tsx

@@ -9,9 +9,9 @@ import { cn, removeFocusOutlines, defaultTextProps } from '~/utils/';
 import { useBookmarkContext } from '~/Providers/BookmarkContext';
 import { useConversationTagMutation } from '~/data-provider';
 import { Checkbox, Label, TextareaAutosize } from '~/components/ui/';
+import { useLocalize, useBookmarkSuccess } from '~/hooks';
 import { NotificationSeverity } from '~/common';
 import { useToastContext } from '~/Providers';
-import { useLocalize } from '~/hooks';
 
 type TBookmarkFormProps = {
   bookmark?: TConversationTag;
@@ -31,10 +31,11 @@ const BookmarkForm = ({
   tags,
   setTags,
 }: TBookmarkFormProps) => {
-  const { showToast } = useToastContext();
   const localize = useLocalize();
-  const mutation = useConversationTagMutation(bookmark?.tag);
+  const { showToast } = useToastContext();
   const { bookmarks } = useBookmarkContext();
+  const mutation = useConversationTagMutation(bookmark?.tag);
+  const onSuccess = useBookmarkSuccess(conversation?.conversationId || '');
 
   const {
     register,
@@ -82,6 +83,7 @@ const BookmarkForm = ({
             (tag) => tag !== undefined,
           ) as string[];
           setTags(newTags);
+          onSuccess(newTags);
         }
       },
       onError: () => {
@@ -172,9 +174,9 @@ const BookmarkForm = ({
                 />
               )}
             />
-            <label
+            <button
+              aria-label={localize('com_ui_bookmarks_add_to_conversation')}
               className="form-check-label text-token-text-primary w-full cursor-pointer"
-              htmlFor="addToConversation"
               onClick={() =>
                 setValue('addToConversation', !getValues('addToConversation'), {
                   shouldDirty: true,
@@ -184,7 +186,7 @@ const BookmarkForm = ({
               <div className="flex select-none items-center">
                 {localize('com_ui_bookmarks_add_to_conversation')}
               </div>
-            </label>
+            </button>
           </div>
         )}
       </div>