2025-06-28 12:35:41 -04:00
|
|
|
const { duplicateAgent } = require('../v1');
|
📦 refactor: Consolidate DB models, encapsulating Mongoose usage in `data-schemas` (#11830)
* chore: move database model methods to /packages/data-schemas
* chore: add TypeScript ESLint rule to warn on unused variables
* refactor: model imports to streamline access
- Consolidated model imports across various files to improve code organization and reduce redundancy.
- Updated imports for models such as Assistant, Message, Conversation, and others to a unified import path.
- Adjusted middleware and service files to reflect the new import structure, ensuring functionality remains intact.
- Enhanced test files to align with the new import paths, maintaining test coverage and integrity.
* chore: migrate database models to packages/data-schemas and refactor all direct Mongoose Model usage outside of data-schemas
* test: update agent model mocks in unit tests
- Added `getAgent` mock to `client.test.js` to enhance test coverage for agent-related functionality.
- Removed redundant `getAgent` and `getAgents` mocks from `openai.spec.js` and `responses.unit.spec.js` to streamline test setup and reduce duplication.
- Ensured consistency in agent mock implementations across test files.
* fix: update types in data-schemas
* refactor: enhance type definitions in transaction and spending methods
- Updated type definitions in `checkBalance.ts` to use specific request and response types.
- Refined `spendTokens.ts` to utilize a new `SpendTxData` interface for better clarity and type safety.
- Improved transaction handling in `transaction.ts` by introducing `TransactionResult` and `TxData` interfaces, ensuring consistent data structures across methods.
- Adjusted unit tests in `transaction.spec.ts` to accommodate new type definitions and enhance robustness.
* refactor: streamline model imports and enhance code organization
- Consolidated model imports across various controllers and services to a unified import path, improving code clarity and reducing redundancy.
- Updated multiple files to reflect the new import structure, ensuring all functionalities remain intact.
- Enhanced overall code organization by removing duplicate import statements and optimizing the usage of model methods.
* feat: implement loadAddedAgent and refactor agent loading logic
- Introduced `loadAddedAgent` function to handle loading agents from added conversations, supporting multi-convo parallel execution.
- Created a new `load.ts` file to encapsulate agent loading functionalities, including `loadEphemeralAgent` and `loadAgent`.
- Updated the `index.ts` file to export the new `load` module instead of the deprecated `loadAgent`.
- Enhanced type definitions and improved error handling in the agent loading process.
- Adjusted unit tests to reflect changes in the agent loading structure and ensure comprehensive coverage.
* refactor: enhance balance handling with new update interface
- Introduced `IBalanceUpdate` interface to streamline balance update operations across the codebase.
- Updated `upsertBalanceFields` method signatures in `balance.ts`, `transaction.ts`, and related tests to utilize the new interface for improved type safety.
- Adjusted type imports in `balance.spec.ts` to include `IBalanceUpdate`, ensuring consistency in balance management functionalities.
- Enhanced overall code clarity and maintainability by refining type definitions related to balance operations.
* feat: add unit tests for loadAgent functionality and enhance agent loading logic
- Introduced comprehensive unit tests for the `loadAgent` function, covering various scenarios including null and empty agent IDs, loading of ephemeral agents, and permission checks.
- Enhanced the `initializeClient` function by moving `getConvoFiles` to the correct position in the database method exports, ensuring proper functionality.
- Improved test coverage for agent loading, including handling of non-existent agents and user permissions.
* chore: reorder memory method exports for consistency
- Moved `deleteAllUserMemories` to the correct position in the exported memory methods, ensuring a consistent and logical order of method exports in `memory.ts`.
2026-02-17 18:23:44 -05:00
|
|
|
const { getAgent, createAgent, getActions } = require('~/models');
|
2025-06-28 12:35:41 -04:00
|
|
|
const { nanoid } = require('nanoid');
|
|
|
|
|
|
📦 refactor: Consolidate DB models, encapsulating Mongoose usage in `data-schemas` (#11830)
* chore: move database model methods to /packages/data-schemas
* chore: add TypeScript ESLint rule to warn on unused variables
* refactor: model imports to streamline access
- Consolidated model imports across various files to improve code organization and reduce redundancy.
- Updated imports for models such as Assistant, Message, Conversation, and others to a unified import path.
- Adjusted middleware and service files to reflect the new import structure, ensuring functionality remains intact.
- Enhanced test files to align with the new import paths, maintaining test coverage and integrity.
* chore: migrate database models to packages/data-schemas and refactor all direct Mongoose Model usage outside of data-schemas
* test: update agent model mocks in unit tests
- Added `getAgent` mock to `client.test.js` to enhance test coverage for agent-related functionality.
- Removed redundant `getAgent` and `getAgents` mocks from `openai.spec.js` and `responses.unit.spec.js` to streamline test setup and reduce duplication.
- Ensured consistency in agent mock implementations across test files.
* fix: update types in data-schemas
* refactor: enhance type definitions in transaction and spending methods
- Updated type definitions in `checkBalance.ts` to use specific request and response types.
- Refined `spendTokens.ts` to utilize a new `SpendTxData` interface for better clarity and type safety.
- Improved transaction handling in `transaction.ts` by introducing `TransactionResult` and `TxData` interfaces, ensuring consistent data structures across methods.
- Adjusted unit tests in `transaction.spec.ts` to accommodate new type definitions and enhance robustness.
* refactor: streamline model imports and enhance code organization
- Consolidated model imports across various controllers and services to a unified import path, improving code clarity and reducing redundancy.
- Updated multiple files to reflect the new import structure, ensuring all functionalities remain intact.
- Enhanced overall code organization by removing duplicate import statements and optimizing the usage of model methods.
* feat: implement loadAddedAgent and refactor agent loading logic
- Introduced `loadAddedAgent` function to handle loading agents from added conversations, supporting multi-convo parallel execution.
- Created a new `load.ts` file to encapsulate agent loading functionalities, including `loadEphemeralAgent` and `loadAgent`.
- Updated the `index.ts` file to export the new `load` module instead of the deprecated `loadAgent`.
- Enhanced type definitions and improved error handling in the agent loading process.
- Adjusted unit tests to reflect changes in the agent loading structure and ensure comprehensive coverage.
* refactor: enhance balance handling with new update interface
- Introduced `IBalanceUpdate` interface to streamline balance update operations across the codebase.
- Updated `upsertBalanceFields` method signatures in `balance.ts`, `transaction.ts`, and related tests to utilize the new interface for improved type safety.
- Adjusted type imports in `balance.spec.ts` to include `IBalanceUpdate`, ensuring consistency in balance management functionalities.
- Enhanced overall code clarity and maintainability by refining type definitions related to balance operations.
* feat: add unit tests for loadAgent functionality and enhance agent loading logic
- Introduced comprehensive unit tests for the `loadAgent` function, covering various scenarios including null and empty agent IDs, loading of ephemeral agents, and permission checks.
- Enhanced the `initializeClient` function by moving `getConvoFiles` to the correct position in the database method exports, ensuring proper functionality.
- Improved test coverage for agent loading, including handling of non-existent agents and user permissions.
* chore: reorder memory method exports for consistency
- Moved `deleteAllUserMemories` to the correct position in the exported memory methods, ensuring a consistent and logical order of method exports in `memory.ts`.
2026-02-17 18:23:44 -05:00
|
|
|
jest.mock('~/models');
|
2025-06-28 12:35:41 -04:00
|
|
|
jest.mock('nanoid');
|
|
|
|
|
|
|
|
|
|
describe('duplicateAgent', () => {
|
|
|
|
|
let req, res;
|
|
|
|
|
|
|
|
|
|
beforeEach(() => {
|
|
|
|
|
req = {
|
|
|
|
|
params: { id: 'agent_123' },
|
|
|
|
|
user: { id: 'user_456' },
|
|
|
|
|
};
|
|
|
|
|
res = {
|
|
|
|
|
status: jest.fn().mockReturnThis(),
|
|
|
|
|
json: jest.fn(),
|
|
|
|
|
};
|
|
|
|
|
jest.clearAllMocks();
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('should duplicate an agent successfully', async () => {
|
|
|
|
|
const mockAgent = {
|
|
|
|
|
id: 'agent_123',
|
|
|
|
|
name: 'Test Agent',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
instructions: 'Test Instructions',
|
|
|
|
|
provider: 'openai',
|
|
|
|
|
model: 'gpt-4',
|
|
|
|
|
tools: ['file_search'],
|
|
|
|
|
actions: [],
|
|
|
|
|
author: 'user_789',
|
|
|
|
|
versions: [{ name: 'Test Agent', version: 1 }],
|
|
|
|
|
__v: 0,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const mockNewAgent = {
|
|
|
|
|
id: 'agent_new_123',
|
|
|
|
|
name: 'Test Agent (1/2/23, 12:34)',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
instructions: 'Test Instructions',
|
|
|
|
|
provider: 'openai',
|
|
|
|
|
model: 'gpt-4',
|
|
|
|
|
tools: ['file_search'],
|
|
|
|
|
actions: [],
|
|
|
|
|
author: 'user_456',
|
|
|
|
|
versions: [
|
|
|
|
|
{
|
|
|
|
|
name: 'Test Agent (1/2/23, 12:34)',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
instructions: 'Test Instructions',
|
|
|
|
|
provider: 'openai',
|
|
|
|
|
model: 'gpt-4',
|
|
|
|
|
tools: ['file_search'],
|
|
|
|
|
actions: [],
|
|
|
|
|
createdAt: new Date(),
|
|
|
|
|
updatedAt: new Date(),
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
getAgent.mockResolvedValue(mockAgent);
|
|
|
|
|
getActions.mockResolvedValue([]);
|
|
|
|
|
nanoid.mockReturnValue('new_123');
|
|
|
|
|
createAgent.mockResolvedValue(mockNewAgent);
|
|
|
|
|
|
|
|
|
|
await duplicateAgent(req, res);
|
|
|
|
|
|
|
|
|
|
expect(getAgent).toHaveBeenCalledWith({ id: 'agent_123' });
|
|
|
|
|
expect(getActions).toHaveBeenCalledWith({ agent_id: 'agent_123' }, true);
|
|
|
|
|
expect(createAgent).toHaveBeenCalledWith(
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
id: 'agent_new_123',
|
|
|
|
|
author: 'user_456',
|
|
|
|
|
name: expect.stringContaining('Test Agent ('),
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
instructions: 'Test Instructions',
|
|
|
|
|
provider: 'openai',
|
|
|
|
|
model: 'gpt-4',
|
|
|
|
|
tools: ['file_search'],
|
|
|
|
|
actions: [],
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
expect(createAgent).toHaveBeenCalledWith(
|
|
|
|
|
expect.not.objectContaining({
|
|
|
|
|
versions: expect.anything(),
|
|
|
|
|
__v: expect.anything(),
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toHaveBeenCalledWith(201);
|
|
|
|
|
expect(res.json).toHaveBeenCalledWith({
|
|
|
|
|
agent: mockNewAgent,
|
|
|
|
|
actions: [],
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('should ensure duplicated agent has clean versions array without nested fields', async () => {
|
|
|
|
|
const mockAgent = {
|
|
|
|
|
id: 'agent_123',
|
|
|
|
|
name: 'Test Agent',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
versions: [
|
|
|
|
|
{
|
|
|
|
|
name: 'Test Agent',
|
|
|
|
|
versions: [{ name: 'Nested' }],
|
|
|
|
|
__v: 1,
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
__v: 2,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
const mockNewAgent = {
|
|
|
|
|
id: 'agent_new_123',
|
|
|
|
|
name: 'Test Agent (1/2/23, 12:34)',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
versions: [
|
|
|
|
|
{
|
|
|
|
|
name: 'Test Agent (1/2/23, 12:34)',
|
|
|
|
|
description: 'Test Description',
|
|
|
|
|
createdAt: new Date(),
|
|
|
|
|
updatedAt: new Date(),
|
|
|
|
|
},
|
|
|
|
|
],
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
getAgent.mockResolvedValue(mockAgent);
|
|
|
|
|
getActions.mockResolvedValue([]);
|
|
|
|
|
nanoid.mockReturnValue('new_123');
|
|
|
|
|
createAgent.mockResolvedValue(mockNewAgent);
|
|
|
|
|
|
|
|
|
|
await duplicateAgent(req, res);
|
|
|
|
|
|
|
|
|
|
expect(mockNewAgent.versions).toHaveLength(1);
|
|
|
|
|
|
|
|
|
|
const firstVersion = mockNewAgent.versions[0];
|
|
|
|
|
expect(firstVersion).not.toHaveProperty('versions');
|
|
|
|
|
expect(firstVersion).not.toHaveProperty('__v');
|
|
|
|
|
|
|
|
|
|
expect(mockNewAgent).not.toHaveProperty('__v');
|
|
|
|
|
|
|
|
|
|
expect(res.status).toHaveBeenCalledWith(201);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('should return 404 if agent not found', async () => {
|
|
|
|
|
getAgent.mockResolvedValue(null);
|
|
|
|
|
|
|
|
|
|
await duplicateAgent(req, res);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toHaveBeenCalledWith(404);
|
|
|
|
|
expect(res.json).toHaveBeenCalledWith({
|
|
|
|
|
error: 'Agent not found',
|
|
|
|
|
status: 'error',
|
|
|
|
|
});
|
|
|
|
|
});
|
|
|
|
|
|
2025-09-18 20:06:59 -04:00
|
|
|
it('should convert `tool_resources.ocr` to `tool_resources.context`', async () => {
|
2025-06-28 12:35:41 -04:00
|
|
|
const mockAgent = {
|
|
|
|
|
id: 'agent_123',
|
|
|
|
|
name: 'Test Agent',
|
|
|
|
|
tool_resources: {
|
|
|
|
|
ocr: { enabled: true, config: 'test' },
|
|
|
|
|
other: { should: 'not be copied' },
|
|
|
|
|
},
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
getAgent.mockResolvedValue(mockAgent);
|
|
|
|
|
getActions.mockResolvedValue([]);
|
|
|
|
|
nanoid.mockReturnValue('new_123');
|
|
|
|
|
createAgent.mockResolvedValue({ id: 'agent_new_123' });
|
|
|
|
|
|
|
|
|
|
await duplicateAgent(req, res);
|
|
|
|
|
|
|
|
|
|
expect(createAgent).toHaveBeenCalledWith(
|
|
|
|
|
expect.objectContaining({
|
|
|
|
|
tool_resources: {
|
2025-09-18 20:06:59 -04:00
|
|
|
context: { enabled: true, config: 'test' },
|
2025-06-28 12:35:41 -04:00
|
|
|
},
|
|
|
|
|
}),
|
|
|
|
|
);
|
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
it('should handle errors gracefully', async () => {
|
|
|
|
|
getAgent.mockRejectedValue(new Error('Database error'));
|
|
|
|
|
|
|
|
|
|
await duplicateAgent(req, res);
|
|
|
|
|
|
|
|
|
|
expect(res.status).toHaveBeenCalledWith(500);
|
|
|
|
|
expect(res.json).toHaveBeenCalledWith({ error: 'Database error' });
|
|
|
|
|
});
|
|
|
|
|
});
|